Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2049)

Unified Diff: ash/launcher/launcher_view.h

Issue 10068027: ash: Fix launcher icon overlaps with status. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove ideal_visibility and move TestAPI out Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/launcher/launcher_view.h
diff --git a/ash/launcher/launcher_view.h b/ash/launcher/launcher_view.h
index dc1d8d1b01985d6a5cb5a5d0253db079c2b03d07..f1bdb63f807dbac0170c606dbc37ed2405f9154b 100644
--- a/ash/launcher/launcher_view.h
+++ b/ash/launcher/launcher_view.h
@@ -25,6 +25,10 @@ class ViewModel;
namespace ash {
+namespace test {
+class LauncherViewTestAPI;
+}
+
class LauncherDelegate;
struct LauncherItem;
class LauncherModel;
@@ -40,23 +44,6 @@ class ASH_EXPORT LauncherView : public views::View,
public views::ContextMenuController,
public views::FocusTraversable {
public:
- // Use the api in this class for testing only.
- class ASH_EXPORT TestAPI {
- public:
- explicit TestAPI(LauncherView* launcher_view)
- : launcher_view_(launcher_view) {
- }
- // Number of icons displayed.
- int GetButtonCount();
- // Retrieve the button at |index|.
- LauncherButton* GetButton(int index);
-
- private:
- LauncherView* launcher_view_;
-
- DISALLOW_COPY_AND_ASSIGN(TestAPI);
- };
-
LauncherView(LauncherModel* model, LauncherDelegate* delegate);
virtual ~LauncherView();
@@ -75,6 +62,8 @@ class ASH_EXPORT LauncherView : public views::View,
virtual View* GetFocusTraversableParentView() OVERRIDE;
private:
+ friend class ash::test::LauncherViewTestAPI;
+
class FadeOutAnimationDelegate;
class StartFadeAnimationDelegate;
@@ -169,6 +158,9 @@ class ASH_EXPORT LauncherView : public views::View,
// item in |model_|.
scoped_ptr<views::ViewModel> view_model_;
+ // Index of the last visible launcher button (does not go into overflow).
+ int last_visible_index_;
+
scoped_ptr<views::BoundsAnimator> bounds_animator_;
views::ImageButton* overflow_button_;

Powered by Google App Engine
This is Rietveld 408576698