gpu/command_buffer/service/framebuffer_manager.h - Issue 10067035: RefCounted types should not have public destructors, media/ and gpu/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/framebuffer_manager.h

Issue 10067035: RefCounted types should not have public destructors, media/ and gpu/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/client/ref_counted.h ('K') | « gpu/command_buffer/service/feature_info.h ('k') | gpu/command_buffer/service/framebuffer_manager.cc » ('j') | media/audio/audio_output_dispatcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/framebuffer_manager.h

diff --git a/gpu/command_buffer/service/framebuffer_manager.h b/gpu/command_buffer/service/framebuffer_manager.h

index d2dcee530b332cbff81ae867f82e514fe6c3e9ae..b9f8704755e60ff0fba1aeb16dcca9500cd6d1cc 100644

--- a/gpu/command_buffer/service/framebuffer_manager.h

+++ b/gpu/command_buffer/service/framebuffer_manager.h

@@ -30,7 +30,6 @@ class GPU_EXPORT FramebufferManager {

public:

typedef scoped_refptr<Attachment> Ref;

- virtual ~Attachment() { }

virtual GLsizei width() const = 0;

virtual GLsizei height() const = 0;

virtual GLenum internal_format() const = 0;

@@ -45,6 +44,10 @@ class GPU_EXPORT FramebufferManager {

virtual bool CanRenderTo() const = 0;

virtual void DetachFromFramebuffer() = 0;

virtual bool ValidForAttachmentType(GLenum attachment_type) = 0;

+ protected:

+ friend base::RefCounted<Attachment>;

+ virtual ~Attachment() {}

};

FramebufferInfo(FramebufferManager* manager, GLuint service_id);