gpu/command_buffer/service/feature_info.h - Issue 10067035: RefCounted types should not have public destructors, media/ and gpu/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/feature_info.h

Issue 10067035: RefCounted types should not have public destructors, media/ and gpu/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/client/ref_counted.h ('K') | « gpu/command_buffer/service/context_group.h ('k') | gpu/command_buffer/service/framebuffer_manager.h » ('j') | media/audio/audio_output_dispatcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/feature_info.h

diff --git a/gpu/command_buffer/service/feature_info.h b/gpu/command_buffer/service/feature_info.h

index 71c9b71dd5075a9972c36a5cda53c6dcdd3b3745..b00830e9be5d5774c1aa7d1f343d704a53283e26 100644

--- a/gpu/command_buffer/service/feature_info.h

+++ b/gpu/command_buffer/service/feature_info.h

@@ -54,7 +54,6 @@ class GPU_EXPORT FeatureInfo : public base::RefCounted<FeatureInfo> {

};

FeatureInfo();

- ~FeatureInfo();

// If allowed features = NULL or "*", all features are allowed. Otherwise

// only features that match the strings in allowed_features are allowed.

@@ -79,6 +78,9 @@ class GPU_EXPORT FeatureInfo : public base::RefCounted<FeatureInfo> {

}

private:

+ friend class base::RefCounted<FeatureInfo>;

+ ~FeatureInfo();

void AddExtensionString(const std::string& str);

Validators validators_;