Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: chrome/browser/ui/login/login_prompt.h

Issue 10067033: RefCounted types should not have public destructors, chrome/browser/ui (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/login/login_prompt.h
diff --git a/chrome/browser/ui/login/login_prompt.h b/chrome/browser/ui/login/login_prompt.h
index d9931f4cab8f2ff138d8a29cd22d322e8de1a243..9fb86f82c08eba645befcc53d1a4bc7b17e2a306 100644
--- a/chrome/browser/ui/login/login_prompt.h
+++ b/chrome/browser/ui/login/login_prompt.h
@@ -36,7 +36,6 @@ class LoginHandler : public content::ResourceDispatcherHostLoginDelegate,
public content::NotificationObserver {
public:
LoginHandler(net::AuthChallengeInfo* auth_info, net::URLRequest* request);
- virtual ~LoginHandler();
// Builds the platform specific LoginHandler. Used from within
// CreateLoginPrompt() which creates tasks.
@@ -84,6 +83,8 @@ class LoginHandler : public content::ResourceDispatcherHostLoginDelegate,
bool WasAuthHandled() const;
protected:
+ virtual ~LoginHandler();
+
void SetModel(LoginModel* model);
void SetDialog(ConstrainedWindow* dialog);

Powered by Google App Engine
This is Rietveld 408576698