Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: chrome/browser/ui/cocoa/first_run_dialog.mm

Issue 10067033: RefCounted types should not have public destructors, chrome/browser/ui (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/first_run_dialog.mm
diff --git a/chrome/browser/ui/cocoa/first_run_dialog.mm b/chrome/browser/ui/cocoa/first_run_dialog.mm
index d061b425ee825bb6546f65fa7f4ac3485d72e158..8b9a66bdedff4189e631896dc5d03d58736420c5 100644
--- a/chrome/browser/ui/cocoa/first_run_dialog.mm
+++ b/chrome/browser/ui/cocoa/first_run_dialog.mm
@@ -57,7 +57,12 @@ class FirstRunShowBridge : public base::RefCounted<FirstRunShowBridge> {
FirstRunShowBridge(FirstRunDialogController* controller);
void ShowDialog();
+
private:
+ friend class base::RefCounted<FirstRunShowBridge>;
+
+ ~FirstRunShowBridge();
+
FirstRunDialogController* controller_;
};
@@ -65,6 +70,8 @@ FirstRunShowBridge::FirstRunShowBridge(
FirstRunDialogController* controller) : controller_(controller) {
}
+FirstRunShowBridge::~FirstRunShowBridge() {}
+
void FirstRunShowBridge::ShowDialog() {
[controller_ show];
MessageLoop::current()->QuitNow();
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/select_file_dialog_mac.mm » ('j') | chrome/browser/ui/cocoa/select_file_dialog_mac.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698