Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2454)

Unified Diff: net/url_request/url_request_job_factory_unittest.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Deprecated cookiestore fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/udp/udp_data_transfer_param.cc ('k') | net/url_request/url_request_netlog_params.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_job_factory_unittest.cc
diff --git a/net/url_request/url_request_job_factory_unittest.cc b/net/url_request/url_request_job_factory_unittest.cc
index 509df0887506a0125cb681262508704a3da9f2cc..975a10626636b48dfa0c9f6262bea09b2571ae67 100644
--- a/net/url_request/url_request_job_factory_unittest.cc
+++ b/net/url_request/url_request_job_factory_unittest.cc
@@ -21,7 +21,7 @@ class MockURLRequestJob : public URLRequestJob {
status_(status),
ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) {}
- virtual void Start() {
+ virtual void Start() OVERRIDE {
// Start reading asynchronously so that all error reporting and data
// callbacks happen as they would for network requests.
MessageLoop::current()->PostTask(
@@ -30,6 +30,9 @@ class MockURLRequestJob : public URLRequestJob {
weak_factory_.GetWeakPtr()));
}
+ protected:
+ virtual ~MockURLRequestJob() {}
+
private:
void StartAsync() {
SetStatus(status_);
@@ -42,7 +45,7 @@ class MockURLRequestJob : public URLRequestJob {
class DummyProtocolHandler : public URLRequestJobFactory::ProtocolHandler {
public:
- virtual URLRequestJob* MaybeCreateJob(URLRequest* request) const {
+ virtual URLRequestJob* MaybeCreateJob(URLRequest* request) const OVERRIDE {
return new MockURLRequestJob(
request, URLRequestStatus(URLRequestStatus::SUCCESS, OK));
}
@@ -52,9 +55,10 @@ class DummyInterceptor : public URLRequestJobFactory::Interceptor {
public:
DummyInterceptor()
: did_intercept_(false),
- handle_all_protocols_(false) { }
+ handle_all_protocols_(false) {
+ }
- virtual URLRequestJob* MaybeIntercept(URLRequest* request) const {
+ virtual URLRequestJob* MaybeIntercept(URLRequest* request) const OVERRIDE {
did_intercept_ = true;
return new MockURLRequestJob(
request,
@@ -63,17 +67,17 @@ class DummyInterceptor : public URLRequestJobFactory::Interceptor {
virtual URLRequestJob* MaybeInterceptRedirect(
const GURL& /* location */,
- URLRequest* /* request */) const {
+ URLRequest* /* request */) const OVERRIDE {
return NULL;
}
virtual URLRequestJob* MaybeInterceptResponse(
- URLRequest* /* request */) const {
+ URLRequest* /* request */) const OVERRIDE {
return NULL;
}
virtual bool WillHandleProtocol(
- const std::string& /* protocol */) const {
+ const std::string& /* protocol */) const OVERRIDE {
return handle_all_protocols_;
}
« no previous file with comments | « net/udp/udp_data_transfer_param.cc ('k') | net/url_request/url_request_netlog_params.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698