RefCounted types should not have public destructors, net/

net/url_request/url_request_job_factory_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_job_factory.h"
 
 #include "base/bind.h"
 #include "base/memory/weak_ptr.h"
 #include "net/url_request/url_request_job.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 namespace {
 
 class MockURLRequestJob : public URLRequestJob {
  public:
   MockURLRequestJob(URLRequest* request, const URLRequestStatus& status)
       : URLRequestJob(request),
         status_(status),
         ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) {}
 
-  virtual void Start() {
+  virtual void Start() OVERRIDE {
     // Start reading asynchronously so that all error reporting and data
     // callbacks happen as they would for network requests.
     MessageLoop::current()->PostTask(
         FROM_HERE,
         base::Bind(&MockURLRequestJob::StartAsync,
                    weak_factory_.GetWeakPtr()));
   }
 
+ protected:
+  virtual ~MockURLRequestJob() {}
+
  private:
   void StartAsync() {
     SetStatus(status_);
     NotifyHeadersComplete();
   }
 
   URLRequestStatus status_;
   base::WeakPtrFactory<MockURLRequestJob> weak_factory_;
 };
 
 class DummyProtocolHandler : public URLRequestJobFactory::ProtocolHandler {
  public:
-  virtual URLRequestJob* MaybeCreateJob(URLRequest* request) const {
+  virtual URLRequestJob* MaybeCreateJob(URLRequest* request) const OVERRIDE {
     return new MockURLRequestJob(
         request, URLRequestStatus(URLRequestStatus::SUCCESS, OK));
   }
 };
 
 class DummyInterceptor : public URLRequestJobFactory::Interceptor {
  public:
   DummyInterceptor()
       : did_intercept_(false),
-        handle_all_protocols_(false) { }
+        handle_all_protocols_(false) {
+  }
 
-  virtual URLRequestJob* MaybeIntercept(URLRequest* request) const {
+  virtual URLRequestJob* MaybeIntercept(URLRequest* request) const OVERRIDE {
     did_intercept_ = true;
     return new MockURLRequestJob(
         request,
         URLRequestStatus(URLRequestStatus::FAILED, ERR_FAILED));
   }
 
   virtual URLRequestJob* MaybeInterceptRedirect(
       const GURL& /* location */,
-      URLRequest* /* request */) const {
+      URLRequest* /* request */) const OVERRIDE {
     return NULL;
   }
 
   virtual URLRequestJob* MaybeInterceptResponse(
-      URLRequest* /* request */) const {
+      URLRequest* /* request */) const OVERRIDE {
     return NULL;
   }
 
   virtual bool WillHandleProtocol(
-      const std::string& /* protocol */) const {
+      const std::string& /* protocol */) const OVERRIDE {
     return handle_all_protocols_;
   }
 
   mutable bool did_intercept_;
   mutable bool handle_all_protocols_;
 };
 
 TEST(URLRequestJobFactoryTest, NoProtocolHandler) {
   TestDelegate delegate;
   scoped_refptr<URLRequestContext> request_context(new TestURLRequestContext);
@@ skipping 115 matching lines @@
   EXPECT_FALSE(interceptor->WillHandleProtocol("anything"));
   EXPECT_FALSE(job_factory.IsHandledProtocol("anything"));
   interceptor->handle_all_protocols_ = true;
   EXPECT_TRUE(interceptor->WillHandleProtocol("anything"));
   EXPECT_TRUE(job_factory.IsHandledProtocol("anything"));
 }
 
 }  // namespace
 
 }  // namespace net