RefCounted types should not have public destructors, net/

net/spdy/spdy_session.cc

Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index 7f39b1772d2a895f5f59d5edd654727bb9908026..7c7e4264904a018902963873b4795d92efdf3c63 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -49,9 +49,6 @@ NetLogSpdySynParameter::NetLogSpdySynParameter(
       associated_stream_(associated_stream) {
 }
 
-NetLogSpdySynParameter::~NetLogSpdySynParameter() {
-}
-
 Value* NetLogSpdySynParameter::ToValue() const {
   DictionaryValue* dict = new DictionaryValue();
   ListValue* headers_list = new ListValue();
@@ -68,6 +65,8 @@ Value* NetLogSpdySynParameter::ToValue() const {
   return dict;
 }
 
+NetLogSpdySynParameter::~NetLogSpdySynParameter() {}
+
 NetLogSpdyCredentialParameter::NetLogSpdyCredentialParameter(
     size_t slot,
     const std::string& origin)
@@ -75,9 +74,6 @@ NetLogSpdyCredentialParameter::NetLogSpdyCredentialParameter(
       origin_(origin) {
 }
 
-NetLogSpdyCredentialParameter::~NetLogSpdyCredentialParameter() {
-}
-
 Value* NetLogSpdyCredentialParameter::ToValue() const {
   DictionaryValue* dict = new DictionaryValue();
   dict->SetInteger("slot", slot_);
@@ -85,13 +81,13 @@ Value* NetLogSpdyCredentialParameter::ToValue() const {
   return dict;
 }
 
+NetLogSpdyCredentialParameter::~NetLogSpdyCredentialParameter() {}
+
 NetLogSpdySessionCloseParameter::NetLogSpdySessionCloseParameter(
     int status,
     const std::string& description)
     : status_(status),
-      description_(description) {}
-
-NetLogSpdySessionCloseParameter::~NetLogSpdySessionCloseParameter() {
+      description_(description) {
 }
 
 Value* NetLogSpdySessionCloseParameter::ToValue() const {
@@ -101,6 +97,8 @@ Value* NetLogSpdySessionCloseParameter::ToValue() const {
   return dict;
 }
 
+NetLogSpdySessionCloseParameter::~NetLogSpdySessionCloseParameter() {}
+
 namespace {
 
 const int kReadBufferSize = 8 * 1024;
@@ -112,13 +110,17 @@ class NetLogSpdySessionParameter : public NetLog::EventParameters {
  public:
   NetLogSpdySessionParameter(const HostPortProxyPair& host_pair)
       : host_pair_(host_pair) {}
+
   virtual Value* ToValue() const {
     DictionaryValue* dict = new DictionaryValue();
     dict->Set("host", new StringValue(host_pair_.first.ToString()));
     dict->Set("proxy", new StringValue(host_pair_.second.ToPacString()));
     return dict;
   }
+
  private:
+  virtual ~NetLogSpdySessionParameter() {}
+
   const HostPortProxyPair host_pair_;
   DISALLOW_COPY_AND_ASSIGN(NetLogSpdySessionParameter);
 };
@@ -142,7 +144,8 @@ class NetLogSpdySettingParameter : public NetLog::EventParameters {
   }
 
  private:
-  ~NetLogSpdySettingParameter() {}
+  virtual ~NetLogSpdySettingParameter() {}
+
   const SpdySettingsIds id_;
   const SpdySettingsFlags flags_;
   const uint32 value_;