RefCounted types should not have public destructors, net/

net/spdy/spdy_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_session.h"
 
 #include <map>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
@@ skipping 31 matching lines @@
     const linked_ptr<SpdyHeaderBlock>& headers,
     SpdyControlFlags flags,
     SpdyStreamId id,
     SpdyStreamId associated_stream)
     : headers_(headers),
       flags_(flags),
       id_(id),
       associated_stream_(associated_stream) {
 }
 
-NetLogSpdySynParameter::~NetLogSpdySynParameter() {
-}
-
 Value* NetLogSpdySynParameter::ToValue() const {
   DictionaryValue* dict = new DictionaryValue();
   ListValue* headers_list = new ListValue();
   for (SpdyHeaderBlock::const_iterator it = headers_->begin();
       it != headers_->end(); ++it) {
     headers_list->Append(new StringValue(base::StringPrintf(
         "%s: %s", it->first.c_str(), it->second.c_str())));
   }
   dict->SetInteger("flags", flags_);
   dict->Set("headers", headers_list);
   dict->SetInteger("id", id_);
   if (associated_stream_)
     dict->SetInteger("associated_stream", associated_stream_);
   return dict;
 }
 
+NetLogSpdySynParameter::~NetLogSpdySynParameter() {}
+
 NetLogSpdyCredentialParameter::NetLogSpdyCredentialParameter(
     size_t slot,
     const std::string& origin)
     : slot_(slot),
       origin_(origin) {
 }
 
-NetLogSpdyCredentialParameter::~NetLogSpdyCredentialParameter() {
-}
-
 Value* NetLogSpdyCredentialParameter::ToValue() const {
   DictionaryValue* dict = new DictionaryValue();
   dict->SetInteger("slot", slot_);
   dict->SetString("origin", origin_);
   return dict;
 }
 
+NetLogSpdyCredentialParameter::~NetLogSpdyCredentialParameter() {}
+
 NetLogSpdySessionCloseParameter::NetLogSpdySessionCloseParameter(
     int status,
     const std::string& description)
     : status_(status),
-      description_(description) {}
-
-NetLogSpdySessionCloseParameter::~NetLogSpdySessionCloseParameter() {
+      description_(description) {
 }
 
 Value* NetLogSpdySessionCloseParameter::ToValue() const {
   DictionaryValue* dict = new DictionaryValue();
   dict->SetInteger("status", status_);
   dict->SetString("description", description_);
   return dict;
 }
 
+NetLogSpdySessionCloseParameter::~NetLogSpdySessionCloseParameter() {}
+
 namespace {
 
 const int kReadBufferSize = 8 * 1024;
 const int kDefaultConnectionAtRiskOfLossSeconds = 10;
 const int kTrailingPingDelayTimeSeconds = 1;
 const int kHungIntervalSeconds = 10;
 
 class NetLogSpdySessionParameter : public NetLog::EventParameters {
  public:
   NetLogSpdySessionParameter(const HostPortProxyPair& host_pair)
       : host_pair_(host_pair) {}
+
   virtual Value* ToValue() const {
     DictionaryValue* dict = new DictionaryValue();
     dict->Set("host", new StringValue(host_pair_.first.ToString()));
     dict->Set("proxy", new StringValue(host_pair_.second.ToPacString()));
     return dict;
   }
+
  private:
+  virtual ~NetLogSpdySessionParameter() {}
+
   const HostPortProxyPair host_pair_;
   DISALLOW_COPY_AND_ASSIGN(NetLogSpdySessionParameter);
 };
 
 class NetLogSpdySettingParameter : public NetLog::EventParameters {
  public:
   explicit NetLogSpdySettingParameter(SpdySettingsIds id,
                                       SpdySettingsFlags flags,
                                       uint32 value)
       : id_(id),
         flags_(flags),
         value_(value) {
   }
 
   virtual Value* ToValue() const {
     DictionaryValue* dict = new DictionaryValue();
     dict->SetInteger("id", id_);
     dict->SetInteger("flags", flags_);
     dict->SetInteger("value", value_);
     return dict;
   }
 
  private:
-  ~NetLogSpdySettingParameter() {}
+  virtual ~NetLogSpdySettingParameter() {}
+
   const SpdySettingsIds id_;
   const SpdySettingsFlags flags_;
   const uint32 value_;
 
   DISALLOW_COPY_AND_ASSIGN(NetLogSpdySettingParameter);
 };
 
 class NetLogSpdySettingsParameter : public NetLog::EventParameters {
  public:
   explicit NetLogSpdySettingsParameter(const SettingsMap& settings)
@@ skipping 1828 matching lines @@
 SSLClientSocket* SpdySession::GetSSLClientSocket() const {
   if (!is_secure_)
     return NULL;
   SSLClientSocket* ssl_socket =
       reinterpret_cast<SSLClientSocket*>(connection_->socket());
   DCHECK(ssl_socket);
   return ssl_socket;
 }
 
 }  // namespace net