Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: net/http/http_stream_factory_impl_job.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Deprecated cookiestore fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_pipelined_connection_impl_unittest.cc ('k') | net/proxy/multi_threaded_proxy_resolver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_job.cc
diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc
index bc4af3089ce9b81792c15538e9d2a20e1f77ebee..b236b5ef066109d12ba380b16d0da87c1d2d3b60 100644
--- a/net/http/http_stream_factory_impl_job.cc
+++ b/net/http/http_stream_factory_impl_job.cc
@@ -51,10 +51,14 @@ class HttpStreamJobParameters : public NetLog::EventParameters {
virtual Value* ToValue() const;
+ protected:
+ virtual ~HttpStreamJobParameters() {}
+
private:
HttpStreamJobParameters(const GURL& original_url, const GURL& url)
: original_url_(original_url.GetOrigin().spec()),
- url_(url.GetOrigin().spec()) {}
+ url_(url.GetOrigin().spec()) {
+ }
const std::string original_url_;
const std::string url_;
@@ -80,13 +84,17 @@ class HttpStreamProtoParameters : public NetLog::EventParameters {
virtual Value* ToValue() const;
+ protected:
+ virtual ~HttpStreamProtoParameters() {}
+
private:
HttpStreamProtoParameters(const SSLClientSocket::NextProtoStatus status,
const std::string& proto,
const std::string& server_protos)
: status_(status),
proto_(proto),
- server_protos_(server_protos) {}
+ server_protos_(server_protos) {
+ }
const SSLClientSocket::NextProtoStatus status_;
const std::string proto_;
« no previous file with comments | « net/http/http_pipelined_connection_impl_unittest.cc ('k') | net/proxy/multi_threaded_proxy_resolver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698