RefCounted types should not have public destructors, net/

net/http/http_stream_factory_impl_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_factory_impl_job.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/logging.h"
 #include "base/stl_util.h"
@@ skipping 33 matching lines @@
 class HttpStreamJobParameters : public NetLog::EventParameters {
  public:
   static scoped_refptr<HttpStreamJobParameters> Create(
       const GURL& original_url,
       const GURL& url) {
     return make_scoped_refptr(new HttpStreamJobParameters(original_url, url));
   }
 
   virtual Value* ToValue() const;
 
+ protected:
+  virtual ~HttpStreamJobParameters() {}
+
  private:
   HttpStreamJobParameters(const GURL& original_url, const GURL& url)
       : original_url_(original_url.GetOrigin().spec()),
-        url_(url.GetOrigin().spec()) {}
+        url_(url.GetOrigin().spec()) {
+  }
 
   const std::string original_url_;
   const std::string url_;
 };
 
 Value* HttpStreamJobParameters::ToValue() const {
   DictionaryValue* dict = new DictionaryValue();
   dict->SetString("original_url", original_url_);
   dict->SetString("url", url_);
   return dict;
 }
 
 // Parameters associated with the Proto (with NPN negotiation) of a HTTP stream.
 class HttpStreamProtoParameters : public NetLog::EventParameters {
  public:
   static scoped_refptr<HttpStreamProtoParameters> Create(
       const SSLClientSocket::NextProtoStatus status,
       const std::string& proto,
       const std::string& server_protos) {
     return make_scoped_refptr(new HttpStreamProtoParameters(
         status, proto, server_protos));
   }
 
   virtual Value* ToValue() const;
 
+ protected:
+  virtual ~HttpStreamProtoParameters() {}
+
  private:
   HttpStreamProtoParameters(const SSLClientSocket::NextProtoStatus status,
                             const std::string& proto,
                             const std::string& server_protos)
       : status_(status),
         proto_(proto),
-        server_protos_(server_protos) {}
+        server_protos_(server_protos) {
+  }
 
   const SSLClientSocket::NextProtoStatus status_;
   const std::string proto_;
   const std::string server_protos_;
 };
 
 Value* HttpStreamProtoParameters::ToValue() const {
   DictionaryValue* dict = new DictionaryValue();
 
   dict->SetString("next_proto_status",
@@ skipping 1137 matching lines @@
     return false;
   }
   if (request_info_.method != "GET" && request_info_.method != "HEAD") {
     return false;
   }
   return stream_factory_->http_pipelined_host_pool_.IsKeyEligibleForPipelining(
       *http_pipelining_key_.get());
 }
 
 }  // namespace net