Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: net/base/host_resolver_impl.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/host_resolver_impl.cc
diff --git a/net/base/host_resolver_impl.cc b/net/base/host_resolver_impl.cc
index 534f3a49721700258f403814a33166b7f2fb0a52..ec6b0db68fe8878d2b849394495d88e0050b37b2 100644
--- a/net/base/host_resolver_impl.cc
+++ b/net/base/host_resolver_impl.cc
@@ -175,6 +175,9 @@ class CallSystemHostResolverProc : public HostResolverProc {
addr_list,
os_error);
}
+
+ private:
+ virtual ~CallSystemHostResolverProc() {}
};
// Extra parameters to attach to the NetLog when the resolve failed.
@@ -217,6 +220,8 @@ class ProcTaskFailedParams : public NetLog::EventParameters {
}
private:
+ virtual ~ProcTaskFailedParams() {}
+
const uint32 attempt_number_;
const int net_error_;
const int os_error_;
@@ -238,6 +243,8 @@ class DnsTaskFailedParams : public NetLog::EventParameters {
}
private:
+ virtual ~DnsTaskFailedParams() {}
+
const int net_error_;
const int dns_error_;
};
@@ -266,6 +273,8 @@ class RequestInfoParameters : public NetLog::EventParameters {
}
private:
+ virtual ~RequestInfoParameters() {}
+
const HostResolver::RequestInfo info_;
const NetLog::Source source_;
};
@@ -285,6 +294,8 @@ class JobCreationParameters : public NetLog::EventParameters {
}
private:
+ virtual ~JobCreationParameters() {}
+
const std::string host_;
const NetLog::Source source_;
};
@@ -304,6 +315,8 @@ class JobAttachParameters : public NetLog::EventParameters {
}
private:
+ virtual ~JobAttachParameters() {}
+
const NetLog::Source source_;
const RequestPriority priority_;
};
@@ -327,6 +340,8 @@ class DnsConfigParameters : public NetLog::EventParameters {
}
private:
+ virtual ~DnsConfigParameters() {}
+
DnsConfig config_; // Does not include DnsHosts to save memory and work.
const size_t num_hosts_;
};
@@ -637,6 +652,9 @@ class HostResolverImpl::ProcTask
}
private:
+ friend base::RefCountedThreadSafe<ProcTask>;
+ virtual ~ProcTask() {}
+
void StartLookupAttempt() {
DCHECK(origin_loop_->BelongsToCurrentThread());
base::TimeTicks start_time = base::TimeTicks::Now();

Powered by Google App Engine
This is Rietveld 408576698