Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: net/websockets/websocket_job_spdy2_unittest.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/websockets/websocket_job_spdy2_unittest.cc
diff --git a/net/websockets/websocket_job_spdy2_unittest.cc b/net/websockets/websocket_job_spdy2_unittest.cc
index 67f4bb1cf0d5e9699496f89c76e54bacdfea6765..16ecb38a7dc888d949b48c64364138994b2c4112 100644
--- a/net/websockets/websocket_job_spdy2_unittest.cc
+++ b/net/websockets/websocket_job_spdy2_unittest.cc
@@ -44,7 +44,6 @@ class MockSocketStream : public net::SocketStream {
public:
MockSocketStream(const GURL& url, net::SocketStream::Delegate* delegate)
: SocketStream(url, delegate) {}
- virtual ~MockSocketStream() {}
virtual void Connect() OVERRIDE {}
virtual bool SendData(const char* data, int len) OVERRIDE {
@@ -66,6 +65,8 @@ class MockSocketStream : public net::SocketStream {
}
private:
+ virtual ~MockSocketStream() {}
+
std::string sent_data_;
};
@@ -235,7 +236,10 @@ class MockCookieStore : public net::CookieStore {
class MockSSLConfigService : public net::SSLConfigService {
public:
- virtual void GetSSLConfig(net::SSLConfig* config) {};
+ virtual void GetSSLConfig(net::SSLConfig* config) OVERRIDE {}
+
+ private:
+ virtual ~MockSSLConfigService() {}
};
class MockURLRequestContext : public net::URLRequestContext {

Powered by Google App Engine
This is Rietveld 408576698