RefCounted types should not have public destructors, net/

net/base/default_server_bound_cert_store.h

Index: net/base/default_server_bound_cert_store.h
diff --git a/net/base/default_server_bound_cert_store.h b/net/base/default_server_bound_cert_store.h
index cd664fe7d4d0b9e4f88b1c21e7743c5b64b47c33..93aa8fc24d5d40bd4f8b1e798783ad98f67e77d0 100644
--- a/net/base/default_server_bound_cert_store.h
+++ b/net/base/default_server_bound_cert_store.h
@@ -129,8 +129,6 @@ typedef base::RefCountedThreadSafe<DefaultServerBoundCertStore::PersistentStore>
 class NET_EXPORT DefaultServerBoundCertStore::PersistentStore
     : public RefcountedPersistentStore {
  public:
-  virtual ~PersistentStore() {}
-
   // Initializes the store and retrieves the existing certs. This will be
   // called only once at startup. Note that the certs are individually allocated
   // and that ownership is transferred to the caller upon return.
@@ -149,7 +147,9 @@ class NET_EXPORT DefaultServerBoundCertStore::PersistentStore
   virtual void Flush(const base::Closure& completion_task) = 0;
 
  protected:
+  friend class base::RefCountedThreadSafe<PersistentStore>;

[wtc, 2012/04/17 23:16:18]

Can we use the RefcountedPersistentStore typedef here for
brevity?  I am not sure if that'll be better though.

[Ryan Sleevi, 2012/04/17 23:42:42]

I'm not sure that's much better. The use of the typedef is itself a bit odd, but
presumably done for line length reasons, as it's never re-used.

   PersistentStore();
+  virtual ~PersistentStore() {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PersistentStore);