RefCounted types should not have public destructors, net/

net/base/default_server_bound_cert_store.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_DEFAULT_SERVER_BOUND_CERT_STORE_H_
 #define NET_BASE_DEFAULT_SERVER_BOUND_CERT_STORE_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 111 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(DefaultServerBoundCertStore);
 };
 
 typedef base::RefCountedThreadSafe<DefaultServerBoundCertStore::PersistentStore>
     RefcountedPersistentStore;
 
 class NET_EXPORT DefaultServerBoundCertStore::PersistentStore
     : public RefcountedPersistentStore {
  public:
-  virtual ~PersistentStore() {}
-
   // Initializes the store and retrieves the existing certs. This will be
   // called only once at startup. Note that the certs are individually allocated
   // and that ownership is transferred to the caller upon return.
   virtual bool Load(
       std::vector<ServerBoundCert*>* certs) = 0;
 
   virtual void AddServerBoundCert(const ServerBoundCert& cert) = 0;
 
   virtual void DeleteServerBoundCert(const ServerBoundCert& cert) = 0;
 
   // Sets the value of the user preference whether the persistent storage
   // must be deleted upon destruction.
   virtual void SetClearLocalStateOnExit(bool clear_local_state) = 0;
 
   // Flush the store and post the given Task when complete.
   virtual void Flush(const base::Closure& completion_task) = 0;
 
  protected:
+  friend class base::RefCountedThreadSafe<PersistentStore>;

[wtc, 2012/04/17 23:16:18]

Can we use the RefcountedPersistentStore typedef here for
brevity?  I am not sure if that'll be better though.

[Ryan Sleevi, 2012/04/17 23:42:42]

I'm not sure that's much better. The use of the typedef is itself a bit odd, but
presumably done for line length reasons, as it's never re-used.

   PersistentStore();
+  virtual ~PersistentStore() {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PersistentStore);
 };
 
 }  // namespace net
 
 #endif  // NET_DEFAULT_ORIGIN_BOUND_CERT_STORE_H_