net/http/http_stream_factory_impl_job.cc - Issue 10066045: RefCounted types should not have public destructors, net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_job.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_stream_factory_impl_job.cc

diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc

index f3ebf4a6027ccd65f58c6889cc64bd549dc67b5d..8625d37b00de9a32cfa00eb4242c6709bcdc1881 100644

--- a/net/http/http_stream_factory_impl_job.cc

+++ b/net/http/http_stream_factory_impl_job.cc

@@ -55,6 +55,7 @@ class HttpStreamJobParameters : public NetLog::EventParameters {

HttpStreamJobParameters(const GURL& original_url, const GURL& url)

: original_url_(original_url.GetOrigin().spec()),

url_(url.GetOrigin().spec()) {}

+ virtual ~HttpStreamJobParameters() {}

const std::string original_url_;

const std::string url_;

@@ -87,6 +88,7 @@ class HttpStreamProtoParameters : public NetLog::EventParameters {

: status_(status),

proto_(proto),

server_protos_(server_protos) {}

+ virtual ~HttpStreamProtoParameters() {}

const SSLClientSocket::NextProtoStatus status_;

const std::string proto_;