Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1654)

Unified Diff: webkit/appcache/view_appcache_internals_job.cc

Issue 10066044: RefCounted types should not have public destructors, webkit/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_url_request_job.cc ('k') | webkit/blob/blob_url_request_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/view_appcache_internals_job.cc
diff --git a/webkit/appcache/view_appcache_internals_job.cc b/webkit/appcache/view_appcache_internals_job.cc
index db1fa54b14d09ba615da71a9eb1cd227ab3c53f0..3c043ba1a866c55673ec17fd4eda11954ee2007d 100644
--- a/webkit/appcache/view_appcache_internals_job.cc
+++ b/webkit/appcache/view_appcache_internals_job.cc
@@ -312,6 +312,7 @@ class BaseInternalsJob : public net::URLRequestSimpleJob {
protected:
BaseInternalsJob(net::URLRequest* request, AppCacheService* service)
: URLRequestSimpleJob(request), appcache_service_(service) {}
+ virtual ~BaseInternalsJob() {}
AppCacheService* appcache_service_;
};
@@ -394,6 +395,9 @@ class RedirectToMainPageJob : public BaseInternalsJob {
*http_status_code = 307;
return true;
}
+
+ protected:
+ virtual ~RedirectToMainPageJob() {}
};
// Job that removes an appcache and then redirects back to the main page.
« no previous file with comments | « webkit/appcache/appcache_url_request_job.cc ('k') | webkit/blob/blob_url_request_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698