Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: webkit/appcache/appcache_url_request_job.cc

Issue 10066044: RefCounted types should not have public destructors, webkit/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_url_request_job.h ('k') | webkit/appcache/view_appcache_internals_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_url_request_job.cc
diff --git a/webkit/appcache/appcache_url_request_job.cc b/webkit/appcache/appcache_url_request_job.cc
index 7d1790965d31c2f55bb02570a23ab1f9809427af..f7f4378d0273256df5ccc9018c0fca5ecb1782ab 100644
--- a/webkit/appcache/appcache_url_request_job.cc
+++ b/webkit/appcache/appcache_url_request_job.cc
@@ -34,11 +34,6 @@ AppCacheURLRequestJob::AppCacheURLRequestJob(
DCHECK(storage_);
}
-AppCacheURLRequestJob::~AppCacheURLRequestJob() {
- if (storage_)
- storage_->CancelDelegateCallbacks(this);
-}
-
void AppCacheURLRequestJob::DeliverAppCachedResponse(
const GURL& manifest_url, int64 group_id, int64 cache_id,
const AppCacheEntry& entry, bool is_fallback) {
@@ -116,6 +111,11 @@ void AppCacheURLRequestJob::BeginDelivery() {
}
}
+AppCacheURLRequestJob::~AppCacheURLRequestJob() {
+ if (storage_)
+ storage_->CancelDelegateCallbacks(this);
+}
+
void AppCacheURLRequestJob::OnResponseInfoLoaded(
AppCacheResponseInfo* response_info, int64 response_id) {
DCHECK(is_delivering_appcache_response());
« no previous file with comments | « webkit/appcache/appcache_url_request_job.h ('k') | webkit/appcache/view_appcache_internals_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698