Issue 10066016: Fix plug-in identifier for Shockwave and add a unit test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10066016: Fix plug-in identifier for Shockwave and add a unit test. (Closed)

Created:
8 years, 8 months ago by Bernhard Bauer

Modified:
8 years, 8 months ago

Reviewers:
jochen (gone - plz use gerrit), Evan Stade

CC:
chromium-reviews, jam, arv (Not doing code reviews), darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix plug-in identifier for Shockwave and add a unit test. TBR=estade@chromium.org BUG=121657 TEST=PluginFinderTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132192

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -20 lines)			Patch
M	chrome/browser/plugin_finder.h	View	3 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/plugin_finder.cc	View	1 chunk	+2 lines, -8 lines	0 comments	Download
M	chrome/browser/plugin_finder_unittest.cc	View	2 chunks	+18 lines, -0 lines	0 comments	Download
M	chrome/browser/plugin_observer.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/plugins_win.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/plugins/npapi/plugin_group.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_list.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_list.cc	View	2 chunks	+8 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10066016/1

8 years, 8 months ago (2012-04-13 13:41:08 UTC) #4

Change committed as 132192