Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: chrome/browser/plugin_observer.cc

Issue 10066016: Fix plug-in identifier for Shockwave and add a unit test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugin_finder_unittest.cc ('k') | chrome/browser/resources/plugins_win.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugin_observer.cc
diff --git a/chrome/browser/plugin_observer.cc b/chrome/browser/plugin_observer.cc
index 1fa79d8fee78566bafde14b272cf9c14425b8f36..f14605b322d54f35663fd9c34c039fd29d91406a 100644
--- a/chrome/browser/plugin_observer.cc
+++ b/chrome/browser/plugin_observer.cc
@@ -218,9 +218,8 @@ void PluginObserver::FindPluginToUpdate(int placeholder_id,
PluginFinder* plugin_finder) {
PluginInstaller* installer =
plugin_finder->FindPluginWithIdentifier(identifier);
- // TODO(bauerb): Remove this CHECK once http://crbug.com/121657 is fixed.
- CHECK(installer) << "Couldn't find PluginInstaller for identifier "
- << identifier;
+ DCHECK(installer) << "Couldn't find PluginInstaller for identifier "
+ << identifier;
plugin_placeholders_[placeholder_id] =
new PluginPlaceholderHost(this, placeholder_id, installer);
InfoBarTabHelper* infobar_helper = tab_contents_->infobar_tab_helper();
« no previous file with comments | « chrome/browser/plugin_finder_unittest.cc ('k') | chrome/browser/resources/plugins_win.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698