chrome/service/cloud_print/cloud_print_connector.h - Issue 10065040: RefCounted types should not have public destructors, chrome/ remaining parts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/cloud_print_connector.h

Issue 10065040: RefCounted types should not have public destructors, chrome/ remaining parts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/service/cloud_print/cloud_print_auth.h ('k') | chrome/service/cloud_print/cloud_print_proxy_backend.cc » ('j') | chrome/service/cloud_print/cloud_print_proxy_backend.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/service/cloud_print/cloud_print_connector.h

diff --git a/chrome/service/cloud_print/cloud_print_connector.h b/chrome/service/cloud_print/cloud_print_connector.h

index a734b211e99983b9d9a9c05cdf6700e234c5f7b5..df16c12efb869180ee0fd65413af63e4d3802945 100644

--- a/chrome/service/cloud_print/cloud_print_connector.h

+++ b/chrome/service/cloud_print/cloud_print_connector.h

@@ -39,7 +39,6 @@ class CloudPrintConnector

const std::string& proxy_id,

const GURL& cloud_print_server_url,

const DictionaryValue* print_system_settings);

- virtual ~CloudPrintConnector();

bool Start();

void Stop();

@@ -73,6 +72,9 @@ class CloudPrintConnector

virtual std::string GetAuthHeader() OVERRIDE;

private:

+ friend class base::RefCountedThreadSafe<CloudPrintConnector>;

+ virtual ~CloudPrintConnector();

// Prototype for a response handler.

typedef CloudPrintURLFetcher::ResponseAction

(CloudPrintConnector::*ResponseHandler)(