chrome/service/cloud_print/cloud_print_proxy_backend.cc - Issue 10065040: RefCounted types should not have public destructors, chrome/ remaining parts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/cloud_print_proxy_backend.cc

Issue 10065040: RefCounted types should not have public destructors, chrome/ remaining parts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/service/cloud_print/cloud_print_connector.h ('k') | chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/service/cloud_print/cloud_print_proxy_backend.cc

diff --git a/chrome/service/cloud_print/cloud_print_proxy_backend.cc b/chrome/service/cloud_print/cloud_print_proxy_backend.cc

index 21c5c0064866b59a0b78629fedecacaee4cb44e9..40eb68e593becc749e6b10d9bef3ce8f6d0996a3 100644

--- a/chrome/service/cloud_print/cloud_print_proxy_backend.cc

+++ b/chrome/service/cloud_print/cloud_print_proxy_backend.cc

@@ -93,6 +93,10 @@ class CloudPrintProxyBackend::Core

virtual void OnOutgoingNotification();

private:

+ friend class base::RefCountedThreadSafe<Core>;

Scott Byer 2012/04/16 17:14:48 nit: extra line

+ virtual ~Core() {}

// NotifyXXX is how the Core communicates with the frontend across

// threads.

void NotifyPrinterListAvailable(