chrome/common/persistent_pref_store.h - Issue 10065040: RefCounted types should not have public destructors, chrome/ remaining parts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/persistent_pref_store.h

Issue 10065040: RefCounted types should not have public destructors, chrome/ remaining parts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/net/gaia/gaia_oauth_client.cc ('k') | chrome/common/service_process_util_mac.mm » ('j') | chrome/service/cloud_print/cloud_print_proxy_backend.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/persistent_pref_store.h

diff --git a/chrome/common/persistent_pref_store.h b/chrome/common/persistent_pref_store.h

index df5a49a7a59457fa2a8378fb3ab1bd075fb66108..69c440b8fbff3db029a9392624c321e078c946e9 100644

--- a/chrome/common/persistent_pref_store.h

+++ b/chrome/common/persistent_pref_store.h

@@ -15,8 +15,6 @@

// the data to some backing store.

class PersistentPrefStore : public PrefStore {

public:

- virtual ~PersistentPrefStore() {}

// Unique integer code for each type of error so we can report them

// distinctly in a histogram.

// NOTE: Don't change the order here as it will change the server's meaning

@@ -85,6 +83,9 @@ class PersistentPrefStore : public PrefStore {

// Lands any pending writes to disk.

virtual void CommitPendingWrite() = 0;

+ protected:

+ virtual ~PersistentPrefStore() {}

};

#endif // CHROME_COMMON_PERSISTENT_PREF_STORE_H_