chrome/common/extensions/extension_permission_set.h - Issue 10065040: RefCounted types should not have public destructors, chrome/ remaining parts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_permission_set.h

Issue 10065040: RefCounted types should not have public destructors, chrome/ remaining parts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/extension_permission_set.h

diff --git a/chrome/common/extensions/extension_permission_set.h b/chrome/common/extensions/extension_permission_set.h

index f42d4c9f934d2e5d9a0e179c7a3a8c8f016d11fd..9e2979aca40a8ffdf211bd646bbccae54824c17a 100644

--- a/chrome/common/extensions/extension_permission_set.h

+++ b/chrome/common/extensions/extension_permission_set.h

@@ -294,8 +294,6 @@ class ExtensionPermissionSet

const URLPatternSet& explicit_hosts,

const URLPatternSet& scriptable_hosts);

- ~ExtensionPermissionSet();

// Creates a new permission set equal to |set1| - |set2|, passing ownership of

// the new set to the caller.

static ExtensionPermissionSet* CreateDifference(

@@ -385,9 +383,10 @@ class ExtensionPermissionSet

private:

FRIEND_TEST_ALL_PREFIXES(ExtensionPermissionsTest,

HasLessHostPrivilegesThan);

friend class base::RefCountedThreadSafe<ExtensionPermissionSet>;

+ ~ExtensionPermissionSet();

static std::set<std::string> GetDistinctHosts(

const URLPatternSet& host_patterns,

bool include_rcd,

« no previous file with comments | « no previous file | chrome/common/json_pref_store.h » ('j') | chrome/service/cloud_print/cloud_print_proxy_backend.cc » ('J')