Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5099)

Unified Diff: chrome/service/cloud_print/printer_job_handler.h

Issue 10065040: RefCounted types should not have public destructors, chrome/ remaining parts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/printer_job_handler.h
diff --git a/chrome/service/cloud_print/printer_job_handler.h b/chrome/service/cloud_print/printer_job_handler.h
index a9de1787c96652d49f276f26c8b292e3486dc35a..b1843c11f47ffe0763bcfe72ec60cc74c0046640 100644
--- a/chrome/service/cloud_print/printer_job_handler.h
+++ b/chrome/service/cloud_print/printer_job_handler.h
@@ -72,6 +72,7 @@ class PrinterJobHandler : public base::RefCountedThreadSafe<PrinterJobHandler>,
INVALID_JOB_DATA,
PRINT_FAILED,
};
+
struct JobDetails {
JobDetails();
~JobDetails();
@@ -109,14 +110,18 @@ class PrinterJobHandler : public base::RefCountedThreadSafe<PrinterJobHandler>,
const GURL& cloud_print_server_url,
cloud_print::PrintSystem* print_system,
Delegate* delegate);
- virtual ~PrinterJobHandler();
+
bool Initialize();
+
std::string GetPrinterName() const;
+
// Requests a job check. |reason| is the reason for fetching the job. Used
// for logging and diagnostc purposes.
void CheckForJobs(const std::string& reason);
+
// Shutdown everything (the process is exiting).
void Shutdown();
+
base::TimeTicks last_job_fetch_time() const { return last_job_fetch_time_; }
// End public interface
@@ -161,6 +166,9 @@ class PrinterJobHandler : public base::RefCountedThreadSafe<PrinterJobHandler>,
// End Delegate implementations
private:
+ friend class base::RefCountedThreadSafe<PrinterJobHandler>;
+ virtual ~PrinterJobHandler();
+
// Prototype for a JSON data handler.
typedef CloudPrintURLFetcher::ResponseAction
(PrinterJobHandler::*JSONDataHandler)(const content::URLFetcher* source,

Powered by Google App Engine
This is Rietveld 408576698