Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2983)

Unified Diff: base/files/file_path_watcher_browsertest.cc

Issue 10065037: RefCounted types should not have public destructors, base/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Typo fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/files/file_path_watcher.h ('k') | base/files/file_path_watcher_kqueue.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/files/file_path_watcher_browsertest.cc
diff --git a/base/files/file_path_watcher_browsertest.cc b/base/files/file_path_watcher_browsertest.cc
index 495f4d3d44c1280dbadc4879687baa0a8304ef06..7886df8de218f00b04b1e3d8401f850d6b4da3ac 100644
--- a/base/files/file_path_watcher_browsertest.cc
+++ b/base/files/file_path_watcher_browsertest.cc
@@ -65,6 +65,9 @@ class NotificationCollector
}
private:
+ friend class base::RefCountedThreadSafe<NotificationCollector>;
+ ~NotificationCollector() {}
+
void RecordChange(TestDelegate* delegate) {
ASSERT_TRUE(loop_->BelongsToCurrentThread());
ASSERT_TRUE(delegates_.count(delegate));
@@ -107,6 +110,9 @@ class TestDelegate : public FilePathWatcher::Delegate {
ADD_FAILURE() << "Error " << path.value();
}
+ protected:
+ virtual ~TestDelegate() {}
+
private:
scoped_refptr<NotificationCollector> collector_;
@@ -249,6 +255,9 @@ class Deleter : public FilePathWatcher::Delegate {
scoped_ptr<FilePathWatcher> watcher_;
MessageLoop* loop_;
+
+ private:
+ virtual ~Deleter() {}
};
// Verify that deleting a watcher during the callback doesn't crash.
« no previous file with comments | « base/files/file_path_watcher.h ('k') | base/files/file_path_watcher_kqueue.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698