Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2024)

Unified Diff: base/memory/ref_counted_memory.h

Issue 10065037: RefCounted types should not have public destructors, base/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/memory/ref_counted_memory.h
diff --git a/base/memory/ref_counted_memory.h b/base/memory/ref_counted_memory.h
index 7b55d145ec20cce12ae1b71ecea819b04f8a2a07..2c1d3ab8de1e0efe36063d4c084a20f6fa4f9da2 100644
--- a/base/memory/ref_counted_memory.h
+++ b/base/memory/ref_counted_memory.h
@@ -49,6 +49,8 @@ class BASE_EXPORT RefCountedStaticMemory : public RefCountedMemory {
virtual size_t size() const OVERRIDE;
private:
+ virtual ~RefCountedStaticMemory();
+
const unsigned char* data_;
size_t length_;
@@ -77,7 +79,6 @@ class BASE_EXPORT RefCountedBytes : public RefCountedMemory {
std::vector<unsigned char>& data() { return data_; }
private:
- friend class base::RefCountedThreadSafe<RefCountedBytes>;
virtual ~RefCountedBytes();
std::vector<unsigned char> data_;
@@ -106,7 +107,6 @@ class BASE_EXPORT RefCountedString : public RefCountedMemory {
std::string& data() { return data_; }
private:
- friend class base::RefCountedThreadSafe<RefCountedString>;
virtual ~RefCountedString();
std::string data_;

Powered by Google App Engine
This is Rietveld 408576698