RefCounted types should not have public destructors, base/ edition

base/threading/worker_pool_unittest.cc

Index: base/threading/worker_pool_unittest.cc
diff --git a/base/threading/worker_pool_unittest.cc b/base/threading/worker_pool_unittest.cc
index 4be06d309de3e1109471768a6ae29f0242554d68..9736b99c85cb17bbd2f330cb7a3423309bf13958 100644
--- a/base/threading/worker_pool_unittest.cc
+++ b/base/threading/worker_pool_unittest.cc
@@ -24,8 +24,7 @@ namespace {
 class PostTaskAndReplyTester
     : public base::RefCountedThreadSafe<PostTaskAndReplyTester> {
  public:
-  PostTaskAndReplyTester() : finished_(false), test_event_(false, false) {
-  }
+  PostTaskAndReplyTester() : finished_(false), test_event_(false, false) {}

[jar (doing other things), 2012/04/14 01:09:38]

nit: This file doesn't seem to use {} on one line... so match the style. (it
also lets you avoid changin' the code ;-) ).

[Ryan Sleevi, 2012/04/24 22:26:01]

In the spirit of unnecessary changes because the style guide said so -
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Constr...

Gives two (and only two) canonical forms. This has been updated to reflect the
first of the Two True Forms.

 
   void RunTest() {
     ASSERT_TRUE(thread_checker_.CalledOnValidThread());
@@ -55,6 +54,9 @@ class PostTaskAndReplyTester
   }
 
  private:
+  friend class base::RefCountedThreadSafe<PostTaskAndReplyTester>;
+  ~PostTaskAndReplyTester() {}
+
   bool finished_;
   WaitableEvent test_event_;