Issue 10038045: RefCounted types should not have public destructors, sql/ and jingle/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10038045: RefCounted types should not have public destructors, sql/ and jingle/ edition (Closed)

Created:
8 years, 8 months ago by Ryan Sleevi

Modified:
8 years, 7 months ago

Reviewers:
Sergey Ulanov, gbillock

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

RefCounted types should not have public destructors, sql/ and jingle/ edition BUG=123295 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134456

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -5 lines)			Patch
M	jingle/glue/pseudotcp_adapter.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	jingle/glue/pseudotcp_adapter_unittest.cc	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download
M	sql/sqlite_features_unittest.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	sql/statement_unittest.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

Greg Billock

On 2012/04/13 09:35:56, Ryan Sleevi wrote: > sergeyu: jingle/ > gbillock: sql/ lgtm sql/*

8 years, 8 months ago (2012-04-13 17:49:56 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10038045/1

8 years, 8 months ago (2012-04-14 01:06:05 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10038045/6001

8 years, 7 months ago (2012-04-28 06:56:26 UTC) #5

Change committed as 134456