Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: sql/sqlite_features_unittest.cc

Issue 10038045: RefCounted types should not have public destructors, sql/ and jingle/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: implementation fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « jingle/glue/pseudotcp_adapter_unittest.cc ('k') | sql/statement_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sql/sqlite_features_unittest.cc
diff --git a/sql/sqlite_features_unittest.cc b/sql/sqlite_features_unittest.cc
index e5cca499727658f61e439f22b9769f66c5f5ac01..d63409eaf4867c457f5732eb88dde8cfe80d5389 100644
--- a/sql/sqlite_features_unittest.cc
+++ b/sql/sqlite_features_unittest.cc
@@ -22,7 +22,7 @@ class StatementErrorHandler : public sql::ErrorDelegate {
StatementErrorHandler() : error_(SQLITE_OK) {}
virtual int OnError(int error, sql::Connection* connection,
- sql::Statement* stmt) {
+ sql::Statement* stmt) OVERRIDE {
error_ = error;
const char* sql_txt = stmt ? stmt->GetSQLStatement() : NULL;
sql_text_ = sql_txt ? sql_txt : "no statement available";
@@ -38,6 +38,9 @@ class StatementErrorHandler : public sql::ErrorDelegate {
const char* sql_statement() const { return sql_text_.c_str(); }
+ protected:
+ virtual ~StatementErrorHandler() {}
+
private:
int error_;
std::string sql_text_;
« no previous file with comments | « jingle/glue/pseudotcp_adapter_unittest.cc ('k') | sql/statement_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698