Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 10031045: Make WindowImpl take into account the icon in the class registrar. (Closed)

Created:
8 years, 8 months ago by Alexei Svitkine (slow)
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Make WindowImpl take into account the icon in the class registrar. This fixes the bug where an incorrect icon was being shown in the Windows Task Manager and Task Switcher. The problem was that the ClassRegistrar was re-using window classes between different windows, but its lookup function was not taking into account the icon. This caused the main Chrome window to take on the class registered by SingletonHwnd, which did not have an icon set. BUG=118368, 117687 TEST=Launch Chrome and check that Chrome's icon looks correct in the Task Manager and Task Switcher. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131673

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M ui/base/win/window_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/win/window_impl.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexei Svitkine (slow)
8 years, 8 months ago (2012-04-10 21:42:40 UTC) #1
sky
LGTM
8 years, 8 months ago (2012-04-10 21:59:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10031045/4001
8 years, 8 months ago (2012-04-10 22:15:03 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-10 23:33:04 UTC) #4
Change committed as 131673

Powered by Google App Engine
This is Rietveld 408576698