Issue 10025022: Pass the list of idl files to fremontcutbuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10025022: Pass the list of idl files to fremontcutbuilder. (Closed)

Created:
8 years, 8 months ago by podivilov

Modified:
8 years, 8 months ago

Reviewers:
Anton Muhin, antonm

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/multivm/trunk/webkit

Visibility:
Public.

More Reviews

Description

Pass the list of idl files to fremontcutbuilder. R=antonm@chromium.org Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=379

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -17 lines)			Patch
	M	Source/WebCore/bindings/dart/gyp/dartium.gyp	View		1 chunk	+3 lines, -15 lines	1 comment	Download
	M	Source/WebCore/bindings/dart/gyp/scripts/generate_dart_bindings.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

8 years, 8 months ago (2012-04-09 14:10:58 UTC) #2

LGTM!

https://chromiumcodereview.appspot.com/10025022/diff/1/Source/WebCore/binding...
File Source/WebCore/bindings/dart/gyp/dartium.gyp (right):

https://chromiumcodereview.appspot.com/10025022/diff/1/Source/WebCore/binding...
Source/WebCore/bindings/dart/gyp/dartium.gyp:23: # Bindings with custom
Objective-C implementations.
just checking, that's how current filters in WebCore.gyp look like?

Expand Messages | Collapse Messages