Issue 100208: - Mark the 'All' target with for getting a runner per http://codereview.chrom...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100208: - Mark the 'All' target with for getting a runner per http://codereview.chrom... (Closed)

Created:
11 years, 7 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

- Mark the 'All' target with for getting a runner per http://codereview.chromium.org/99223 - Add a new target to build just what's needed for the webkit layout bots. - Roll deps for the needed GYP change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14969

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	build/all.gyp	View	1	2 chunks	+18 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

http://codereview.chromium.org/100208/diff/1/2 File build/all.gyp (right): http://codereview.chromium.org/100208/diff/1/2#newcode22 Line 22: 'xcode_create_dependents_test_runner': 1, What's this?

11 years, 7 months ago (2009-04-30 16:57:40 UTC) #2

Mark Mentovai

LG % use_this_style http://codereview.chromium.org/100208/diff/1/2 File build/all.gyp (right): http://codereview.chromium.org/100208/diff/1/2#newcode85 Line 85: 'target_name': 'BuildForLayoutTests', None of our ...

11 years, 7 months ago (2009-04-30 17:58:09 UTC) #3

Mark Mentovai

11 years, 7 months ago (2009-04-30 17:58:48 UTC) #4

Also, add a DEPS bump to this change before committing.

Expand Messages | Collapse Messages