Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5897)

Unified Diff: chrome/browser/gtk/bookmark_bubble_gtk.cc

Issue 100203: Implement a mostly working InfoBubble with a shim BookmarkBubble. (Closed)
Patch Set: Comments Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/gtk/bookmark_bubble_gtk.cc
diff --git a/chrome/browser/gtk/bookmark_bubble_gtk.cc b/chrome/browser/gtk/bookmark_bubble_gtk.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3ea219722bad7847f40e60234000cb6d1f94c87d
--- /dev/null
+++ b/chrome/browser/gtk/bookmark_bubble_gtk.cc
@@ -0,0 +1,26 @@
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/gtk/bookmark_bubble_gtk.h"
+
+#include <gtk/gtk.h>
+
+#include "base/basictypes.h"
+#include "base/logging.h"
+#include "chrome/browser/gtk/info_bubble_gtk.h"
+
+// static
+void BookmarkBubbleGtk::Show(const gfx::Rect& rect,
+ Profile* profile,
+ const GURL& url,
+ bool newly_bookmarked) {
+ // TODO(deanm): Implement the real bookmark bubble. For now we just have
+ // a placeholder for testing that input and focus works correctly.
+ GtkWidget* content = gtk_vbox_new(FALSE, 5);
+ gtk_box_pack_start(GTK_BOX(content), gtk_label_new("Hej!"), TRUE, TRUE, 0);
+ gtk_box_pack_start(GTK_BOX(content), gtk_entry_new(), TRUE, TRUE, 0);
+ gtk_box_pack_start(GTK_BOX(content), gtk_entry_new(), TRUE, TRUE, 0);
+ InfoBubbleGtk* bubble = InfoBubbleGtk::Show(rect, content);
+ DCHECK(bubble);
ecattell 2009/04/30 19:55:37 Please provide some logging output for this check.
Dean McNamee 2009/05/01 15:01:46 I generally try to avoid DCHECK strings unless the
+}

Powered by Google App Engine
This is Rietveld 408576698