Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/browser/gtk/bookmark_bubble_gtk.cc

Issue 100203: Implement a mostly working InfoBubble with a shim BookmarkBubble. (Closed)
Patch Set: Comments Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/gtk/bookmark_bubble_gtk.h"
6
7 #include <gtk/gtk.h>
8
9 #include "base/basictypes.h"
10 #include "base/logging.h"
11 #include "chrome/browser/gtk/info_bubble_gtk.h"
12
13 // static
14 void BookmarkBubbleGtk::Show(const gfx::Rect& rect,
15 Profile* profile,
16 const GURL& url,
17 bool newly_bookmarked) {
18 // TODO(deanm): Implement the real bookmark bubble. For now we just have
19 // a placeholder for testing that input and focus works correctly.
20 GtkWidget* content = gtk_vbox_new(FALSE, 5);
21 gtk_box_pack_start(GTK_BOX(content), gtk_label_new("Hej!"), TRUE, TRUE, 0);
22 gtk_box_pack_start(GTK_BOX(content), gtk_entry_new(), TRUE, TRUE, 0);
23 gtk_box_pack_start(GTK_BOX(content), gtk_entry_new(), TRUE, TRUE, 0);
24 InfoBubbleGtk* bubble = InfoBubbleGtk::Show(rect, content);
25 DCHECK(bubble);
ecattell 2009/04/30 19:55:37 Please provide some logging output for this check.
Dean McNamee 2009/05/01 15:01:46 I generally try to avoid DCHECK strings unless the
26 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698