Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5084)

Unified Diff: build/common.gypi

Issue 100189: Code coverage improvements.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 15005)
+++ build/common.gypi (working copy)
@@ -72,16 +72,13 @@
}],
],
}],
- # TODO(jrg): complete this work once Linux transitions to gyp.
- # This is untested (--> likely doesn't work).
+ # Linux gyp (into scons) doesn't like target_conditions?
+ # TODO(???): track down why 'target_conditions' doesn't work
+ # on Linux gyp into scons like it does on Mac gyp into xcodeproj.
['OS=="linux"', {
'cflags': [ '-ftest-coverage',
'-fprofile-arcs' ],
- 'target_conditions': [
- ['_type=="executable"', {
- 'link_settings': { 'libraries': [ '-lgcov' ] },
- }],
- ],
+ 'link_settings': { 'libraries': [ '-lgcov' ] },
}],
]},
# TODO(jrg): options for code coverage on Windows
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698