Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8214)

Unified Diff: chrome/chrome.gyp

Issue 100189: Code coverage improvements.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | tools/code_coverage/coverage_posix.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome.gyp
===================================================================
--- chrome/chrome.gyp (revision 15005)
+++ chrome/chrome.gyp (working copy)
@@ -2997,8 +2997,7 @@
]}, # 'targets'
], # OS=="win"
# TODO(jrg): add in Windows code coverage targets.
- # Also test on Linux.
- ['coverage!=0 and OS=="mac"',
+ ['coverage!=0 and OS!="win"',
{ 'targets': [
{
'target_name': 'coverage',
@@ -3008,16 +3007,26 @@
'type': 'none',
'dependencies': [
'../base/base.gyp:base_unittests',
+ '../media/media.gyp:media_unittests',
+ '../net/net.gyp:net_unittests',
+ '../printing/printing.gyp:printing_unittests',
],
'actions': [
{
+ # 'message' for Linux/scons in particular
+ 'message': 'Running coverage_posix.py to generate coverage numbers',
'inputs': [],
'outputs': [],
'action_name': 'coverage',
'action': [ 'python',
'../tools/code_coverage/coverage_posix.py',
'--directory',
- '<(PRODUCT_DIR)' ],
+ '<(PRODUCT_DIR)',
+ '--',
+ '<@(_dependencies)'],
+ # Use outputs of this action as inputs for the main target build.
+ # Seems as a misnomer but makes this happy on Linux (scons).
+ 'process_outputs_as_sources': 1,
},
], # 'actions'
},
« no previous file with comments | « build/common.gypi ('k') | tools/code_coverage/coverage_posix.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698