Code coverage improvements....

Code coverage improvements.

Code coverage now works for Linux.  Unit tests to run passed from
project to coverage_posix.py so deps are correct.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15016

[sgk, 2009-04-30 21:44:35]

http://codereview.chromium.org/100189/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/100189/diff/1/2#newcode78
Line 78: # Linux gyp (into scons) doesn't like target_conditions?
Hmm, maybe add a TODO here?  I don't think there should be any platform
differences w.r.t. target_conditions, but maybe there's something the scons
generator isn't doing right.

http://codereview.chromium.org/100189/diff/1/4
File chrome/chrome.gyp (right):

http://codereview.chromium.org/100189/diff/1/4#newcode2951
Line 2951: 'process_outputs_as_sources': 1,
This shouldn't be necessary any more; I believe it's left over from our earlier
attempts to make this work.  Take it out, and let me know if that seems to
actually break things.

http://codereview.chromium.org/100189/diff/1/3
File tools/code_coverage/coverage_posix.py (right):

http://codereview.chromium.org/100189/diff/1/3#newcode12
Line 12: All platforms, to setup coverage:
nit:  "set up"

http://codereview.chromium.org/100189/diff/1/3#newcode120
Line 120: print 'coverage: ' + ' '.join(self.tests)
leftover debug print?

http://codereview.chromium.org/100189/diff/1/3#newcode169
Line 169: print ' '.join(sys.argv)
debug print?

[John Grabowski, 2009-04-30 23:03:21]

http://codereview.chromium.org/100189/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/100189/diff/1/2#newcode78
Line 78: # Linux gyp (into scons) doesn't like target_conditions?
On 2009/04/30 21:44:35, sgk wrote:
> Hmm, maybe add a TODO here?  I don't think there should be any platform
> differences w.r.t. target_conditions, but maybe there's something the scons
> generator isn't doing right.

Expanded.  The TODO isn't for me but it's added.

http://codereview.chromium.org/100189/diff/1/4
File chrome/chrome.gyp (right):

http://codereview.chromium.org/100189/diff/1/4#newcode2951
Line 2951: 'process_outputs_as_sources': 1,
On 2009/04/30 21:44:35, sgk wrote:
> This shouldn't be necessary any more; I believe it's left over from our
earlier
> attempts to make this work.  Take it out, and let me know if that seems to
> actually break things.

Still needed.  Without it nothing happens.

http://codereview.chromium.org/100189/diff/1/3
File tools/code_coverage/coverage_posix.py (right):

http://codereview.chromium.org/100189/diff/1/3#newcode12
Line 12: All platforms, to setup coverage:
On 2009/04/30 21:44:35, sgk wrote:
> nit:  "set up"

fixed

http://codereview.chromium.org/100189/diff/1/3#newcode120
Line 120: print 'coverage: ' + ' '.join(self.tests)
On 2009/04/30 21:44:35, sgk wrote:
> leftover debug print?

removed

http://codereview.chromium.org/100189/diff/1/3#newcode169
Line 169: print ' '.join(sys.argv)
On 2009/04/30 21:44:35, sgk wrote:
> debug print?

removed

[sgk, 2009-04-30 23:12:19]

lgtm