add .pak files to list of grd outputs (so make can compute dependencies)

Fix make build by making sure .pak files are listed as outputs of grd files.

Specifically:
1) In webkit.gyp and test_shell.gyp, convert the rules to actions because of different grd outputs (localized grd files have locale in the .pak filename).
2) In chrome, make two targets each with a custom rule.  One target is for localized resources, the other for non-localized resources.  This is like the current windows build.

[Evan Martin, 2009-04-30 17:58:42]

LGTM if it doesn't break win/mac

http://codereview.chromium.org/100174/diff/1/2
File chrome/chrome.gyp (right):

http://codereview.chromium.org/100174/diff/1/2#newcode116
Line 116: 'chrome_strings',
It would be nice if all of these weren't necessary.  But maybe that's outside
the scope of this commit.

[tony, 2009-04-30 22:11:29]

Adding mark and brad to the review.

[Evan Martin, 2009-04-30 22:12:26]

Perhaps a better description than "fix the make build" would be "make rules
match reality".  :P

[Mark Mentovai, 2009-04-30 22:22:35]

I guess this LG.

http://codereview.chromium.org/100174/diff/1/4
File webkit/tools/test_shell/test_shell.gyp (right):

http://codereview.chromium.org/100174/diff/1/4#newcode468
Line 468: 'actions': [
What are we gaining by turning this into an action from a rule?

Nothing against the change really, I'm just assuming that you've done it for a
reason but I don't see what's actually changing.

[bradn, 2009-04-30 22:29:52]

http://codereview.chromium.org/100174/diff/1/4
File webkit/tools/test_shell/test_shell.gyp (right):

http://codereview.chromium.org/100174/diff/1/4#newcode484
Line 484: 'process_outputs_as_mac_bundle_resources': 1,
We still do want the message, I do plan to add it for windows, there's a bug,
just haven't gotten to it.

http://codereview.chromium.org/100174/diff/8/12
File webkit/webkit.gyp (right):

http://codereview.chromium.org/100174/diff/8/12#newcode4274
Line 4274: {
Any chance we can actually split this back into a separate webkit_string target?
That would match windows now, and reduce the seam I need to patch in slns and
vcprojs. Then you could give this part msvs_guid
60B43839-95E6-4526-A661-209F16335E0E so it's a drop-in for the current vcproj. I
think I asked mark about this once, but it would make my life easier in the
near-term.

[tony, 2009-04-30 22:31:13]

On 2009/04/30 22:22:35, Mark Mentovai wrote:
> I guess this LG.
> 
> http://codereview.chromium.org/100174/diff/1/4
> File webkit/tools/test_shell/test_shell.gyp (right):
> 
> http://codereview.chromium.org/100174/diff/1/4#newcode468
> Line 468: 'actions': [
> What are we gaining by turning this into an action from a rule?
> 
> Nothing against the change really, I'm just assuming that you've done it for a
> reason but I don't see what's actually changing.

Actually, nothing.  It's a bit cleaner and more concise as an action since
there's only one input, but it shouldn't matter either way (same with
net_resources.grd which I didn't convert).  I'm happy to take the change out if
you want.

[tony, 2009-04-30 22:39:26]

On 2009/04/30 22:29:52, bradn wrote:
> http://codereview.chromium.org/100174/diff/1/4
> File webkit/tools/test_shell/test_shell.gyp (right):
> 
> http://codereview.chromium.org/100174/diff/1/4#newcode484
> Line 484: 'process_outputs_as_mac_bundle_resources': 1,
> We still do want the message, I do plan to add it for windows, there's a bug,
> just haven't gotten to it.

I don't think actions have messages.  Maybe I'm mistaken?


> http://codereview.chromium.org/100174/diff/8/12
> File webkit/webkit.gyp (right):
> 
> http://codereview.chromium.org/100174/diff/8/12#newcode4274
> Line 4274: {
> Any chance we can actually split this back into a separate webkit_string
target?
> That would match windows now, and reduce the seam I need to patch in slns and
> vcprojs. Then you could give this part msvs_guid
> 60B43839-95E6-4526-A661-209F16335E0E so it's a drop-in for the current vcproj.
I
> think I asked mark about this once, but it would make my life easier in the
> near-term.

Sure, I've gone ahead and added this as a separate target.

[tony, 2009-04-30 22:54:04]

Ok, 'message' strings added to the new actions.