Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1512)

Unified Diff: chrome/chrome.gyp

Issue 100174: add .pak files to list of grd outputs (so make can compute dependencies) (Closed)
Patch Set: rebase Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | chrome/installer/util/util.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome.gyp
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp
index ffce28c4e818da1f9767f1b201130b822a90d7bc..e6e01b998a9a9c02437ad628779e22bf195bf28d 100644
--- a/chrome/chrome.gyp
+++ b/chrome/chrome.gyp
@@ -42,7 +42,7 @@
# to run grit would list its own .grd files, but unfortunately some
# of the static libraries currently have circular dependencies among
# generated headers.
- 'target_name': 'resources',
+ 'target_name': 'chrome_resources',
'type': 'none',
'rules': [
{
@@ -53,18 +53,15 @@
],
'outputs': [
'<(SHARED_INTERMEDIATE_DIR)/chrome/grit/<(RULE_INPUT_ROOT).h',
+ '<(SHARED_INTERMEDIATE_DIR)/chrome/<(RULE_INPUT_ROOT).pak',
],
'action': ['python', '<@(_inputs)', '-i', '<(RULE_INPUT_PATH)', 'build', '-o', '<(SHARED_INTERMEDIATE_DIR)/chrome'],
'message': 'Generating resources from <(RULE_INPUT_PATH)',
},
],
'sources': [
- # All .grd files under chrome.
- 'app/resources/locale_settings.grd',
+ # Data resources.
'app/theme/theme_resources.grd',
- 'app/chromium_strings.grd',
- 'app/generated_resources.grd',
- 'app/google_chrome_strings.grd',
'browser/debugger/resources/debugger_resources.grd',
'browser/browser_resources.grd',
'common/common_resources.grd',
@@ -77,10 +74,46 @@
},
},
{
+ # TODO(mark): It would be better if each static library that needed
+ # to run grit would list its own .grd files, but unfortunately some
+ # of the static libraries currently have circular dependencies among
+ # generated headers.
+ 'target_name': 'chrome_strings',
+ 'type': 'none',
+ 'rules': [
+ {
+ 'rule_name': 'grit',
+ 'extension': 'grd',
+ 'inputs': [
+ '../tools/grit/grit.py',
+ ],
+ 'outputs': [
+ '<(SHARED_INTERMEDIATE_DIR)/chrome/grit/<(RULE_INPUT_ROOT).h',
+ '<(SHARED_INTERMEDIATE_DIR)/chrome/<(RULE_INPUT_ROOT)_en-US.pak',
+ ],
+ 'action': ['python', '<@(_inputs)', '-i', '<(RULE_INPUT_PATH)', 'build', '-o', '<(SHARED_INTERMEDIATE_DIR)/chrome'],
+ 'message': 'Generating resources from <(RULE_INPUT_PATH)',
+ },
+ ],
+ 'sources': [
+ # Localizable resources.
+ 'app/resources/locale_settings.grd',
+ 'app/chromium_strings.grd',
+ 'app/generated_resources.grd',
+ 'app/google_chrome_strings.grd',
+ ],
+ 'direct_dependent_settings': {
+ 'include_dirs': [
+ '<(SHARED_INTERMEDIATE_DIR)/chrome',
+ ],
+ },
+ },
+ {
'target_name': 'common',
'type': '<(library)',
'dependencies': [
- 'resources',
+ 'chrome_resources',
+ 'chrome_strings',
'../base/base.gyp:base',
'../base/base.gyp:base_gfx',
'../build/temp_gyp/googleurl.gyp:googleurl',
@@ -361,7 +394,8 @@
'type': '<(library)',
'dependencies': [
'common',
- 'resources',
+ 'chrome_resources',
+ 'chrome_strings',
'../media/media.gyp:media',
'../net/net.gyp:net_resources',
'../skia/skia.gyp:skia',
@@ -1477,7 +1511,8 @@
'type': '<(library)',
'dependencies': [
'common',
- 'resources',
+ 'chrome_resources',
+ 'chrome_strings',
'../media/media.gyp:media',
'../skia/skia.gyp:skia',
'../third_party/icu38/icu38.gyp:icui18n',
@@ -1534,7 +1569,8 @@
'dependencies': [
'common',
'plugin',
- 'resources',
+ 'chrome_resources',
+ 'chrome_strings',
'../printing/printing.gyp:printing',
'../skia/skia.gyp:skia',
'../third_party/icu38/icu38.gyp:icui18n',
@@ -1913,7 +1949,8 @@
'browser',
'common',
'renderer',
- 'resources',
+ 'chrome_resources',
+ 'chrome_strings',
'../skia/skia.gyp:skia',
'../testing/gtest.gyp:gtest',
],
@@ -1984,7 +2021,8 @@
'type': '<(library)',
'dependencies': [
'test_support_common',
- 'resources',
+ 'chrome_resources',
+ 'chrome_strings',
'../skia/skia.gyp:skia',
'../testing/gtest.gyp:gtest',
],
@@ -2019,7 +2057,8 @@
'type': '<(library)',
'dependencies': [
'test_support_common',
- 'resources',
+ 'chrome_resources',
+ 'chrome_strings',
'../skia/skia.gyp:skia',
'../testing/gtest.gyp:gtest',
],
@@ -2072,7 +2111,8 @@
'app',
'browser',
'common',
- 'resources',
+ 'chrome_resources',
+ 'chrome_strings',
'test_support_ui',
'../base/base.gyp:base',
'../net/net.gyp:net',
@@ -2218,7 +2258,8 @@
'browser',
'common',
'renderer',
- 'resources',
+ 'chrome_resources',
+ 'chrome_strings',
'test_support_unit',
'../printing/printing.gyp:printing',
'../webkit/webkit.gyp:webkit',
@@ -2535,7 +2576,8 @@
'app',
'browser',
'common',
- 'resources',
+ 'chrome_resources',
+ 'chrome_strings',
'test_support_ui',
'../base/base.gyp:base',
'../skia/skia.gyp:skia',
@@ -2567,7 +2609,8 @@
'target_name': 'page_cycler_tests',
'type': 'executable',
'dependencies': [
- 'resources',
+ 'chrome_resources',
+ 'chrome_strings',
'test_support_ui',
'../base/base.gyp:base',
'../skia/skia.gyp:skia',
@@ -2663,7 +2706,8 @@
'browser',
'common',
'renderer',
- 'resources',
+ 'chrome_resources',
+ 'chrome_strings',
'../base/base.gyp:base',
'../base/base.gyp:test_support_base',
'../skia/skia.gyp:skia',
@@ -2701,7 +2745,8 @@
'type': '<(library)',
'dependencies': [
'common',
- 'resources',
+ 'chrome_resources',
+ 'chrome_strings',
'../media/media.gyp:media',
'../skia/skia.gyp:skia',
'../third_party/icu38/icu38.gyp:icui18n',
« no previous file with comments | « DEPS ('k') | chrome/installer/util/util.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698