Issue 100156: Unbreak IA32 generated code coverage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100156: Unbreak IA32 generated code coverage. (Closed)

Created:
11 years, 7 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Unbreak IA32 generated code coverage. Committed: http://code.google.com/p/v8/source/detail?r=1814

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -10 lines)			Patch
	M	src/ia32/codegen-ia32.cc	View		3 chunks	+9 lines, -6 lines	1 comment	Download
	M	src/ia32/jump-target-ia32.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 7 months ago (2009-04-29 09:56:46 UTC) #2

LGTM

http://codereview.chromium.org/100156/diff/1/2
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/100156/diff/1/2#newcode5424
Line 5424: // size which allows the assert below to succeed and patching to
work.
Should you explain the motivation for these other uses of masm, that __ can emit
additional instructions in debug or profiling modes?

Expand Messages | Collapse Messages