Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: src/ia32/jump-target-ia32.cc

Issue 100156: Unbreak IA32 generated code coverage. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/ia32/codegen-ia32.cc ('K') | « src/ia32/codegen-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 // around the merge code on the fall through path. 108 // around the merge code on the fall through path.
109 Label original_fall_through; 109 Label original_fall_through;
110 __ j(NegateCondition(cc), &original_fall_through, NegateHint(hint)); 110 __ j(NegateCondition(cc), &original_fall_through, NegateHint(hint));
111 cgen_->frame()->MergeTo(entry_frame_); 111 cgen_->frame()->MergeTo(entry_frame_);
112 cgen_->DeleteFrame(); 112 cgen_->DeleteFrame();
113 __ jmp(&entry_label_); 113 __ jmp(&entry_label_);
114 cgen_->SetFrame(fall_through_frame, &non_frame_registers); 114 cgen_->SetFrame(fall_through_frame, &non_frame_registers);
115 __ bind(&original_fall_through); 115 __ bind(&original_fall_through);
116 116
117 } else { 117 } else {
118 // Forward branch. A copy of the current frame is added to the end 118 // Forward branch. A copy of the current frame is added to the end of the
119 // of the list of frames reaching the target block and a branch to 119 // list of frames reaching the target block and a branch to the merge code
120 // the merge code is emitted. 120 // is emitted. Use masm_-> instead of __ as forward branches are expected
121 // to be a fixed size (no inserted coverage-checking instructions please).
122 // This is used in Reference::GetValue.
121 AddReachingFrame(new VirtualFrame(cgen_->frame())); 123 AddReachingFrame(new VirtualFrame(cgen_->frame()));
122 __ j(cc, &merge_labels_.last(), hint); 124 masm_->j(cc, &merge_labels_.last(), hint);
123 is_linked_ = true; 125 is_linked_ = true;
124 } 126 }
125 } 127 }
126 128
127 129
128 void JumpTarget::Call() { 130 void JumpTarget::Call() {
129 // Call is used to push the address of the catch block on the stack as 131 // Call is used to push the address of the catch block on the stack as
130 // a return address when compiling try/catch and try/finally. We 132 // a return address when compiling try/catch and try/finally. We
131 // fully spill the frame before making the call. The expected frame 133 // fully spill the frame before making the call. The expected frame
132 // at the label (which should be the only one) is the spilled current 134 // at the label (which should be the only one) is the spilled current
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 } 328 }
327 329
328 is_linked_ = false; 330 is_linked_ = false;
329 is_bound_ = true; 331 is_bound_ = true;
330 } 332 }
331 333
332 #undef __ 334 #undef __
333 335
334 336
335 } } // namespace v8::internal 337 } } // namespace v8::internal
OLDNEW
« src/ia32/codegen-ia32.cc ('K') | « src/ia32/codegen-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698