Issue 100087: Take 3 at turning on -Werror. This passed the last run on the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100087: Take 3 at turning on -Werror. This passed the last run on the (Closed)

Created:
11 years, 8 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
dank, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Take 3 at turning on -Werror. This passed the last run on the buildbots, except for the valgrind bots which use -O1. For now, just disable -Werror on the bots with an override.

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	build/common.gypi	View		3 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

Before I commit this, I will update the .gyp/include.gypi file on the bots to have: ...

11 years, 8 months ago (2009-04-28 00:35:02 UTC) #1

LGTM

Expand Messages | Collapse Messages