Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3713)

Unified Diff: build/common.gypi

Issue 100087: Take 3 at turning on -Werror. This passed the last run on the (Closed)
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 49b030dad07a9696fe333360db56106530c01183..93e9df9d03339fdcb7796376d8f53cfa672776cc 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -147,6 +147,11 @@
# are compatible with the general 32-bit-ness.
'-32',
],
+ # Enable -Werror by default, but put it in a variable so it can
+ # be disabled in ~/.gyp/include.gypi on the valgrind builders.
+ 'variables': {
+ 'werror%': '-Werror',
+ },
# All floating-point computations on x87 happens in 80-bit
# precision. Because the C and C++ language standards allow
# the compiler to keep the floating-point values in higher
@@ -180,8 +185,7 @@
'-msse2',
'-mfpmath=sse',
'-Wall',
- # TODO(sgk): when chromium_code targets are clean of warnings.
- #'-Werror',
+ '<(werror)', # See note above about the werror variable.
],
'ldflags': [
'-m32',
@@ -258,7 +262,7 @@
'ldflags': [
'-rdynamic', # Allows backtrace to resolve symbols.
],
- },
+ },
'Release': {
'cflags': [
'-O2',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698