Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 10008102: gdata: Use PLOG() instead of strerror() when logging system errors. (Closed)

Created:
8 years, 8 months ago by Ben Chan
Modified:
8 years, 8 months ago
Reviewers:
satorux1, kuan
CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

gdata: Use PLOG() instead of strerror() when logging system errors. BUG=chromium-os:29418 TEST=Run "unit_tests --gtest_filter='*GData*'" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M chrome/browser/chromeos/gdata/gdata_file_system.cc View 4 chunks +12 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ben Chan
8 years, 8 months ago (2012-04-13 06:50:15 UTC) #1
satorux1
LGTM
8 years, 8 months ago (2012-04-13 07:25:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benchan@chromium.org/10008102/1
8 years, 8 months ago (2012-04-13 07:40:02 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-13 09:03:39 UTC) #4
Change committed as 132160

Powered by Google App Engine
This is Rietveld 408576698