gdata: Use PLOG() instead of strerror() when logging system errors.

chrome/browser/chromeos/gdata/gdata_file_system.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/gdata/gdata_file_system.h"
 
 #include <errno.h>
 
 #include <utility>
 
@@ skipping 175 matching lines @@
     const std::vector<FilePath>& paths_to_create) {
   base::PlatformFileError error = base::PLATFORM_FILE_OK;
 
   for (size_t i = 0; i < paths_to_create.size(); ++i) {
     if (file_util::DirectoryExists(paths_to_create[i]))
       continue;
 
     if (!file_util::CreateDirectory(paths_to_create[i])) {
       // Error creating this directory, record error and proceed with next one.
       error = SystemToPlatformError(errno);
-      LOG(ERROR) << "Error creating dir " << paths_to_create[i].value()
-                 << ": \"" << strerror(errno)
-                 << "\", " << error;
+      PLOG(ERROR) << "Error creating directory " << paths_to_create[i].value();
     } else {
-      DVLOG(1) << "Created dir " << paths_to_create[i].value();
+      DVLOG(1) << "Created directory " << paths_to_create[i].value();
     }
   }
 
   return error;
 }
 
 // Modifies cache state of file on IO thread pool, which involves:
 // - moving or copying file (per |file_operation_type|) from |source_path| to
 //  |dest_path| if they're different
 // - deleting symlink if |symlink_path| is not empty
 // - creating symlink if |symlink_path| is not empty and |create_symlink| is
 //   true.
 base::PlatformFileError ModifyCacheState(
     const FilePath& source_path,
     const FilePath& dest_path,
     GDataFileSystem::FileOperationType file_operation_type,
     const FilePath& symlink_path,
     bool create_symlink) {
   // Move or copy |source_path| to |dest_path| if they are different.
   if (source_path != dest_path) {
     bool success = false;
     if (file_operation_type == GDataFileSystem::FILE_OPERATION_MOVE)
       success = file_util::Move(source_path, dest_path);
     else if (file_operation_type ==
         GDataFileSystem::FILE_OPERATION_COPY)
       success = file_util::CopyFile(source_path, dest_path);
     if (!success) {
       base::PlatformFileError error = SystemToPlatformError(errno);
-      LOG(ERROR) << "Error "
-                 << (file_operation_type ==
-                     GDataFileSystem::FILE_OPERATION_MOVE ?
-                     "moving " : "copying ")
-                 << source_path.value()
-                 << " to " << dest_path.value()
-                 << ": " << strerror(errno);
+      PLOG(ERROR) << "Error "
+                  << (file_operation_type ==
+                      GDataFileSystem::FILE_OPERATION_MOVE ?
+                      "moving " : "copying ")
+                  << source_path.value()
+                  << " to " << dest_path.value();
       return error;
     } else {
       DVLOG(1) << (file_operation_type ==
                    GDataFileSystem::FILE_OPERATION_MOVE ?
                    "Moved " : "Copied ")
                << source_path.value()
                << " to " << dest_path.value();
     }
   } else {
     DVLOG(1) << "No need to move file: source = destination";
@@ skipping 26 matching lines @@
 
   // We try to save one file operation by not checking if link exists before
   // deleting it, so unlink may return error if link doesn't exist, but it
   // doesn't really matter to us.
   bool deleted = HANDLE_EINTR(unlink(symlink_path.value().c_str())) == 0;
   if (deleted) {
     DVLOG(1) << "Deleted symlink " << symlink_path.value();
   } else {
     // Since we didn't check if symlink exists before deleting it, don't log
     // if symlink doesn't exist.
-    if (errno != ENOENT) {
-      LOG(WARNING) << "Error deleting symlink " << symlink_path.value()
-                   << ": " << strerror(errno);
-    }
+    if (errno != ENOENT)
+      PLOG(WARNING) << "Error deleting symlink " << symlink_path.value();
   }
 
   if (!create_symlink)
     return base::PLATFORM_FILE_OK;
 
   // Create new symlink to |dest_path|.
   if (!file_util::CreateSymbolicLink(dest_path, symlink_path)) {
     base::PlatformFileError error = SystemToPlatformError(errno);
-    LOG(ERROR) << "Error creating symlink " << symlink_path.value()
-               << " for " << dest_path.value()
-               << ": " << strerror(errno);
+    PLOG(ERROR) << "Error creating symlink " << symlink_path.value()
+                << " for " << dest_path.value();
     return error;
   } else {
     DVLOG(1) << "Created symlink " << symlink_path.value()
              << " to " << dest_path.value();
   }
 
   return base::PLATFORM_FILE_OK;
 }
 
 // Deletes all files that match |path_to_delete_pattern| except for
@@ skipping 3833 matching lines @@
   pref_registrar_->Init(profile_->GetPrefs());
   pref_registrar_->Add(prefs::kDisableGDataHostedFiles, this);
 }
 
 void SetFreeDiskSpaceGetterForTesting(FreeDiskSpaceGetterInterface* getter) {
   delete global_free_disk_getter_for_testing;  // Safe to delete NULL;
   global_free_disk_getter_for_testing = getter;
 }
 
 }  // namespace gdata