Add ctrl+drag feature for allowing resizing window with exact positioning.

Add ctrl+drag feature for allowing resizing window with exact positioning.


BUG=116077
TEST=ctrl+drag will allow resizing window with exact positioning, drag resizing will still snap to grid.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132497

[sky, 2012-04-12 18:08:14]

Also, be sure add test coverage.

http://codereview.chromium.org/10008084/diff/1009/ash/wm/default_window_resiz...
File ash/wm/default_window_resizer.cc (right):

http://codereview.chromium.org/10008084/diff/1009/ash/wm/default_window_resiz...
ash/wm/default_window_resizer.cc:50:
AdjustBoundsToGrid(details_.window->bounds(), details_.grid_size));
Isn't this going to snap it to the grid?

Now that we need to dynamically change the grid size, I think it's to error
prone to bake the grid size into Details. Instead pass it around. That way we're
sure someone doesn't accidentally use the wrong thing.

[jennyz, 2012-04-12 18:25:16]

http://codereview.chromium.org/10008084/diff/1009/ash/wm/default_window_resiz...
File ash/wm/default_window_resizer.cc (right):

http://codereview.chromium.org/10008084/diff/1009/ash/wm/default_window_resiz...
ash/wm/default_window_resizer.cc:50:
AdjustBoundsToGrid(details_.window->bounds(), details_.grid_size));
CompleteDrag is only called when user release the mouse press for moving a
window, not for resizing a window. So I don't think we need to change the snap
to grid behavior for moving windows. But I agree that it is kind of error prone
to bake the grid size in Details now, I will take it out of the Details and pass
it around as a parameter.
On 2012/04/12 18:08:14, sky wrote:
> Isn't this going to snap it to the grid?
> 
> Now that we need to dynamically change the grid size, I think it's to error
> prone to bake the grid size into Details. Instead pass it around. That way
we're
> sure someone doesn't accidentally use the wrong thing.

[sky, 2012-04-12 19:38:39]

I spoke with Nicholas and he said that if we do control-dragging to move off
grid, we should do control-dragging for resize too.

[jennyz, 2012-04-13 21:11:07]

I have added ctrl-drag for moving window to exact position, also removed
grid_size from Details.

[jennyz, 2012-04-13 21:12:48]

By the way, I am not sure how Resize and CompleteResize of
MultiWindowResizeController is called, and if we need to pass mouse event flag
into them or not. WindowResizer::Drag and CompleteDrag are called from these
functions. Please advise.

[sky, 2012-04-13 21:44:14]

Look in the .cc, they're called from ResizeView.

  -Scott

On Fri, Apr 13, 2012 at 2:12 PM,  <jennyz@chromium.org> wrote:
> By the way, I am not sure how Resize and CompleteResize of
> MultiWindowResizeController is called, and if we need to pass mouse event
> flag
> into them or not. WindowResizer::Drag and CompleteDrag are called from these
> functions. Please advise.
>
> http://codereview.chromium.org/10008084/

[jennyz, 2012-04-16 18:18:23]

Added event_flag to MultiWindowResizeController's Resize and CompleteResize
functions.

[sky, 2012-04-16 21:16:30]

LGTM

http://codereview.chromium.org/10008084/diff/19001/ash/wm/window_resizer.h
File ash/wm/window_resizer.h (right):

http://codereview.chromium.org/10008084/diff/19001/ash/wm/window_resizer.h#ne...
ash/wm/window_resizer.h:52: // flags from mouse event.
'from mouse' -> 'from the'

http://codereview.chromium.org/10008084/diff/19001/ash/wm/workspace/workspace...
File ash/wm/workspace/workspace_window_resizer.cc (right):

http://codereview.chromium.org/10008084/diff/19001/ash/wm/workspace/workspace...
ash/wm/workspace/workspace_window_resizer.cc:203: const gfx::Rect& bounds, int
grid_size) const {
grid_size on its own line (212 too).

[jennyz, 2012-04-16 23:09:40]

http://codereview.chromium.org/10008084/diff/19001/ash/wm/window_resizer.h
File ash/wm/window_resizer.h (right):

http://codereview.chromium.org/10008084/diff/19001/ash/wm/window_resizer.h#ne...
ash/wm/window_resizer.h:52: // flags from mouse event.
On 2012/04/16 21:16:30, sky wrote:
> 'from mouse' -> 'from the'

Done.

http://codereview.chromium.org/10008084/diff/19001/ash/wm/workspace/workspace...
File ash/wm/workspace/workspace_window_resizer.cc (right):

http://codereview.chromium.org/10008084/diff/19001/ash/wm/workspace/workspace...
ash/wm/workspace/workspace_window_resizer.cc:203: const gfx::Rect& bounds, int
grid_size) const {
On 2012/04/16 21:16:30, sky wrote:
> grid_size on its own line (212 too).

Done.

[commit-bot: I haz the power, 2012-04-16 23:10:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennyz@chromium.org/10008084/20014

[commit-bot: I haz the power, 2012-04-17 00:55:31]

Change committed as 132497