Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: webkit/fileapi/file_writer_delegate.cc

Issue 10008047: FileWriterDelegate should not call URLRequest::Start() after Cancel(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/fileapi/file_writer_delegate.cc
diff --git a/webkit/fileapi/file_writer_delegate.cc b/webkit/fileapi/file_writer_delegate.cc
index d95e00be3ec1108307db8ec2204d79a80d355e31..0b741c1eef5bf1216120ac6a0775b7ff82479aaf 100644
--- a/webkit/fileapi/file_writer_delegate.cc
+++ b/webkit/fileapi/file_writer_delegate.cc
@@ -114,6 +114,10 @@ void FileWriterDelegate::OnGetFileInfoAndCallStartUpdate(
OnError(error);
return;
}
+ if (request_->status().status() == net::URLRequestStatus::CANCELED) {
ericu 2012/04/09 16:14:22 This looks more like "Don't call Start after Cance
+ OnError(base::PLATFORM_FILE_ERROR_ABORT);
+ return;
+ }
int64 allowed_bytes_growth =
file_system_operation_context()->allowed_bytes_growth();
if (allowed_bytes_growth < 0)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698