FileWriterDelegate should not call URLRequest::Start() after Cancel().

webkit/fileapi/file_writer_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/file_writer_delegate.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/file_util_proxy.h"
 #include "base/message_loop.h"
@@ skipping 96 matching lines @@
 FileWriterDelegate::~FileWriterDelegate() {
 }
 
 void FileWriterDelegate::OnGetFileInfoAndCallStartUpdate(
     base::PlatformFileError error,
     const base::PlatformFileInfo& file_info) {
   if (error) {
     OnError(error);
     return;
   }
+  if (request_->status().status() == net::URLRequestStatus::CANCELED) {

[ericu, 2012/04/09 16:14:22]

This looks more like "Don't call Start after Cancel" than "Don't call Cancel
before Start".  Is that what you wanted?  To prevent a call of Cancel before
Start I think you'd want to put code in OnError instead.

+    OnError(base::PLATFORM_FILE_ERROR_ABORT);
+    return;
+  }
   int64 allowed_bytes_growth =
       file_system_operation_context()->allowed_bytes_growth();
   if (allowed_bytes_growth < 0)
     allowed_bytes_growth = 0;
   int64 overlap = file_info.size - offset_;
   allowed_bytes_to_write_ = allowed_bytes_growth;
   if (kint64max - overlap > allowed_bytes_growth)
     allowed_bytes_to_write_ += overlap;
   size_ = file_info.size;
   file_stream_.reset(new net::FileStream(
@@ skipping 192 matching lines @@
 
 FileSystemQuotaUtil* FileWriterDelegate::quota_util() const {
   DCHECK(file_system_operation_);
   DCHECK(file_system_operation_->file_system_context());
   DCHECK(file_system_operation_->file_system_operation_context());
   return file_system_operation_->file_system_context()->GetQuotaUtil(
       path_.type());
 }
 
 }  // namespace fileapi