Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 10007034: aura: Change shared context to be offscreen for arm (Closed)

Created:
8 years, 8 months ago by piman
Modified:
8 years, 8 months ago
Reviewers:
sky, apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

aura: Change shared context to be offscreen for arm ARM drivers don't like to have 2 EGLSurface on the same Window. So we need to make the UI shared context offscren. This also requires the image transport surface to be an "offscreen" GLSurface (a pbuffer), however the GLES2Decoder needs to be "onscreen" (i.e. it calls SwapBuffers on the surface instead managing the offscreen buffers itself). So this decouples the 2 notions of "offscreen". BUG=chrome-os-partner:8284 TEST=gpu_unittests. Aura chrome --ui-use-gpu-process with poster circle and webgl on tegra, lumpy, desktop GL. Desktop chrome with poster circle and webgl. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131177 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133975

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -30 lines) Patch
M content/browser/renderer_host/image_transport_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/texture_image_transport_surface.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 2 chunks +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 4 chunks +26 lines, -26 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/demos/framework/window.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
piman
apatrick: please review sky: OWNERS in content/browser/renderer_host
8 years, 8 months ago (2012-04-06 06:22:01 UTC) #1
sky
LGTM
8 years, 8 months ago (2012-04-06 15:59:15 UTC) #2
apatrick_chromium
lgtm
8 years, 8 months ago (2012-04-06 17:55:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10007034/1
8 years, 8 months ago (2012-04-06 18:02:26 UTC) #4
commit-bot: I haz the power
Change committed as 131177
8 years, 8 months ago (2012-04-06 20:11:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10007034/1
8 years, 8 months ago (2012-04-25 16:43:32 UTC) #6
commit-bot: I haz the power
Try job failure for 10007034-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-25 17:02:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10007034/13004
8 years, 8 months ago (2012-04-25 19:15:19 UTC) #8
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 20:52:25 UTC) #9
Change committed as 133975

Powered by Google App Engine
This is Rietveld 408576698